Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Midi import: various small improvements #2006

Merged
merged 7 commits into from
Jun 17, 2015
Merged

Commits on May 5, 2015

  1. MIDI import: don't call AutomationPattern::addObject all the time

    Should be enough to add the object to the automation pattern only once,
    as the objModel variable that is added will always be the same for the
    same value of ccid, which indexes the ccs array.
    
    This will speed up creation of automation tracks for MIDI CCs and pitch
    bend.
    softrabbit committed May 5, 2015
    Configuration menu
    Copy the full SHA
    ff44854 View commit details
    Browse the repository at this point in the history
  2. MIDI import: ensure minimum note length 1 tick

    Too short notes had their duration rounded down to 0 on import,
    as MIDI precision allows way shorter notes than LMMS, and
    portsmf reports the duration as a double, where a beat == 1.0.
    
    Was going to use ceil() first, but that might round some notes
    up to a slightly longer duration.
    softrabbit committed May 5, 2015
    Configuration menu
    Copy the full SHA
    2a72d5f View commit details
    Browse the repository at this point in the history
  3. MIDI import: add naming of AutomationTracks

    Name the automation tracks like "[MIDI trackname] CC ##". And don't
    call the automation track creation function for every CC event, as
    it now will involve constructing a QString.
    softrabbit committed May 5, 2015
    Configuration menu
    Copy the full SHA
    61ab0ed View commit details
    Browse the repository at this point in the history
  4. MIDI import: call qApp->processEvents(); before creating tracks

    This should keep LMMS responsive from the window managers POV, unless
    the user selects a huge enough default sound font that loading it
    takes too long.
    softrabbit committed May 5, 2015
    Configuration menu
    Copy the full SHA
    06d8717 View commit details
    Browse the repository at this point in the history
  5. MIDI import: set default pitch bend range to +/-2 semitones

    AFAIK, this is how the General MIDI standard says it should be.
    softrabbit committed May 5, 2015
    Configuration menu
    Copy the full SHA
    542250e View commit details
    Browse the repository at this point in the history
  6. Clarified the reason for qApp->processEvents(),

    changed an odd type juggling into something slightly saner.
    softrabbit committed May 5, 2015
    Configuration menu
    Copy the full SHA
    22b1e4f View commit details
    Browse the repository at this point in the history

Commits on May 18, 2015

  1. Configuration menu
    Copy the full SHA
    c4f4fe3 View commit details
    Browse the repository at this point in the history