Drop PresetPreviewPlayHandle's shared buffer system #2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, add the NotePlayHandle used for previewing directly to the mixer. This fixes two preview problems, namely the shared buffer being released by the NotePlayHandle but still being pulled in by the AudioPort resulting in distortions, and certain previews being cut off at mouse release even if a release was set in the envelope.
|
Note that I have one doubt about this solution: it effectively makes PresetPreviewPlayHandle a dummy PlayHandle. Not a perfect score for conceptual soundness. But hey, I chased this bug for hours today 😲. If anyone has suggestions for a more elegant solution, I'll be happy to look into them tomorrow. |
|
FYI this pull request has been tested at #2434 (comment) and #2575 (comment) with good results. Therefore, this PR is ready to merge as far as I'm concerned. |
|
Merging. It's rock solid as testing goes but I can't give any feedback on the coding but it's been discussed here in issue 2434. |
zonkmachine
added a commit
that referenced
this pull request
Feb 23, 2016
Drop PresetPreviewPlayHandle's shared buffer system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, add the NotePlayHandle used for previewing directly to the mixer. Fixes #2434 and certain previews being cut off at mouse release even if a release was set in the envelope. Testing welcome!