rename tracks directly on TrackLableButton in a QLineEdit #2916
Conversation
|
👍 👍 |
|
I cleaned up the code a little bit. |
|
I get these errors when using compact track buttons: |
|
@jasp00 Thank you for revisiting this PR. I have exclude the resize in case of compact track buttons now. |
| { | ||
| setFixedSize( 32, 29 ); | ||
| } | ||
| else | ||
| { | ||
| setFixedSize( 160, 29 ); | ||
| m_renameLineEdit = new QLineEdit(this); | ||
| m_renameLineEdit->move( 30, (height() / 2) - ( m_renameLineEdit->sizeHint().height() / 2 ) ); | ||
| m_renameLineEdit->setFixedWidth( this->width() - 33 ); |
There was a problem hiding this comment.
Why this->width() instead of width()?
Updated |
|
@Umcaruje no, the button is labeled with setText(). That's no QLabel or PaintEvent. |
|
^ right. The difference here is we have a button object already that we're working from, which would make the task much more difficult. In the case of the Mixer, it was just a label, making the consolidation a no-brainer. One could argue to abolish the button altogether, but then the button-press behavior would have to be painted, we'd essentially find ourselves making a new button-like class and the underlying logic would look very much like what's been done already. @Umcaruje I had thought of that too when I made the recommendation on the Mixer and then realized it's a button paint (or in this case a |
|
Just to let you know: if a track or a fx is renamed Lmms does not consider the project as modified. |
rename tracks directly on TrackLableButton in a QLineEdit
With this one we can edit the track name directly in the track. This avoids a dialog window.