Disable minimization on all subwindows #2983
Merged
+18
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My 2 cents: If we do decide to git rid of the minimize button, it seems to me that the maximize icon could be changed. That specific kind of maximize icon is used with a minimize icon very frequently, whereas a "full screen" style icon is not always paired with a minimize icon. @Umcaruje I actually think that you have already created an icon like what I am thinking for the title bars in the past. I found the link to it. |
Umcaruje
force-pushed
the
nominimizenomore
branch
from
178c5be
to
b41ef0e
Compare
|
Here's how it looks with the new icon: This is rebased, conflicts removed and ready to be merged. |
|
I think this is much better, not only get rid of further bugs relating to
the minimize button, but also beautified the icons
|
|
I'll test this out, tonight. |
|
After some discussion over on Discord @RebeccaDeField modified the maximize icon so it fits better with the close icon: |
|
Okay, let's see what the people say. |
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
* Disable minimization on all subwindows * Change the maximize button icon * Remove redundant boolean * Make the maximize icon play better with the close icon * I removed too much maaan * Fix spaces * Change comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2976
All subwindows now have a flag set to disable the minimize button. I have also removed its drawing code and pixmaps. EffectView was also modified to properly set the window flags. Screenshot: