fix eliding issue on fx mixer fader #3241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miketurn @musikBear can you test this? |
Bump. @BaraMGB I don't see this on linux. |
|
@zonkmachine yes it depends on the used font. You can see it on Windows. In this PR the font metrics is calculated on the fader label font. Before that it's calculated on the widgets font and delivered wrong values. |
|
@BaraMGB sorry, yes i will dl and test Tested. |
|
Then this should be merged. Any objections here @zonkmachine? |
|
@BaraMGB |
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3237
Windows builds for testing can be found here: https:/BaraMGB/lmms/releases/tag/v1.2rc2.8