Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TimeLineWidget overflow #3410

Merged
merged 1 commit into from
Mar 8, 2017
Merged

Fix TimeLineWidget overflow #3410

merged 1 commit into from
Mar 8, 2017

Conversation

zonkmachine
Copy link
Member

In response to #3284

@zonkmachine zonkmachine merged commit 9545f96 into LMMS:master Mar 8, 2017
@lukas-w
Copy link
Member

lukas-w commented Mar 8, 2017 •
edited
Loading

I think it would be best to fix all occurrences (see comment) by providing a function that does this, and using that instead of having the same calculation seven times in a single file.

@zonkmachine
Copy link
Member Author

I think it would be best to fix all occurrences (see comment) by providing a function that does this, and using that instead of having the same calculation seven times in a single file.

OK. I left #3284 open so maybe continue there?

@zonkmachine zonkmachine deleted the timelineoverflow branch March 13, 2017 18:09
@lukas-w
Copy link
Member

lukas-w commented Mar 13, 2017

Yup.

sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
@zonkmachine
Fix TimeLineWidget overflow (LMMS#3410)
e3a1088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zonkmachine @lukas-w