Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix export project for sampletracks with vst effects on it #3571

Merged
merged 2 commits into from
May 29, 2017
Merged

fix export project for sampletracks with vst effects on it #3571

merged 2 commits into from
May 29, 2017

Conversation

BaraMGB
Copy link
Contributor

@BaraMGB BaraMGB commented May 21, 2017

fixes #3511

Umcaruje
Umcaruje approved these changes May 21, 2017
View reviewed changes
Copy link
Member

@Umcaruje Umcaruje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, this fixes the issue 👍

@BaraMGB
Copy link
Contributor Author

BaraMGB commented May 22, 2017

Okay, but now we don't need this anymore:

connect( gui->songEditor(), SIGNAL( playTriggered() ), this, SLOT( playbackPositionChanged() ) );

I'll remove that.

@BaraMGB
Copy link
Contributor Author

BaraMGB commented May 23, 2017

I guess I merge this tomorrow.

@Spekular
Copy link
Member

@BaraMGB did something come up or should this be merged?

I guess I merge this tomorrow.

@BaraMGB BaraMGB merged commit 1eef218 into LMMS:stable-1.2 May 29, 2017
@BaraMGB
Copy link
Contributor Author

BaraMGB commented May 29, 2017

@Spekular 👍

PhysSong pushed a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017
@BaraMGB @PhysSong
fix export project for sampletracks with vst effects on it (LMMS#3571)
6c84104 
* fix export project for sampletracks with vst effects on it

* removed playTriggered Signal
PhysSong pushed a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017
@BaraMGB @PhysSong
fix export project for sampletracks with vst effects on it (LMMS#3571)
addecb3 
* fix export project for sampletracks with vst effects on it

* removed playTriggered Signal
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
@BaraMGB
fix export project for sampletracks with vst effects on it (LMMS#3571)
8c8939f 
* fix export project for sampletracks with vst effects on it

* removed playTriggered Signal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Umcaruje Umcaruje Umcaruje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sample Tracks won't export if they have VST effects on them
3 participants
@BaraMGB @Spekular @Umcaruje