Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FLAC export and related options #3731

Merged
merged 20 commits into from
Aug 3, 2017
Merged

Add FLAC export and related options #3731

merged 20 commits into from
Aug 3, 2017

Commits on Jul 26, 2017

  1. Add FLAC export, based on WAV renderer

    @irrenhaus3
    Levin authored and irrenhaus3 committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    5f1c9dc View commit details
    Browse the repository at this point in the history

  2. Indent with TAB character

    @irrenhaus3
    irrenhaus3 committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    b41bbab View commit details
    Browse the repository at this point in the history

  3. Depend on sndfile>=1.0.18 (previously >=1.0.11)

    @irrenhaus3
    irrenhaus3 committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    ed7a4b6 View commit details
    Browse the repository at this point in the history

  4. Introduces new CPP definition LMMS_SF_HAVE_CMPLEVEL 

    This symbol is defined if libsndfile is available in version >= 1.0.26 and thus has the command SF_SET_COMPRESSION_LEVEL.
    @irrenhaus3
    irrenhaus3 committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    d7bb49a View commit details
    Browse the repository at this point in the history

  5. Add compression option to FLAC export, if available. 

    The code related to compression is only generated if LMMS_HAVE_SF_COMPLEVEL is defined. Otherwise, the UI element for it will exist in the mockup, but stay hidden, and the underlying functionality is not available at all.
    @irrenhaus3
    irrenhaus3 committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    36354a8 View commit details
    Browse the repository at this point in the history

  6. Save into the correct file extension upon export.

    @irrenhaus3
    irrenhaus3 committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    8fe7994 View commit details
    Browse the repository at this point in the history

  7. Use unique_ptr in FLAC renderer and be more expressive about involved… 

    … types.
    @irrenhaus3
    irrenhaus3 committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    5ba265f View commit details
    Browse the repository at this point in the history

  8. Enable compression setting unconditionally, only use the SF_COMPLEVEL… 

    … condition in GUI and FLAC-renderer.
    @irrenhaus3
    irrenhaus3 committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    caba25e View commit details
    Browse the repository at this point in the history

  9. Use unique_ptr and remove manual memory management in ExportProjectDi… 

    …alog
    @irrenhaus3
    irrenhaus3 committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    f89475d View commit details
    Browse the repository at this point in the history

  10. Populate compLevelCB unconditionally and make its strings translatable.

    @irrenhaus3
    irrenhaus3 committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    dfe6a69 View commit details
    Browse the repository at this point in the history

  11. Remove unused #include statement.

    @irrenhaus3
    irrenhaus3 committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    9d24ebc View commit details
    Browse the repository at this point in the history

  12. Fixed a silly typo.

    @irrenhaus3
    irrenhaus3 committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    14b6ce3 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2017

  1. Remove use of deprecated symbol QApplication::UnicodeUTF8

    @irrenhaus3
    irrenhaus3 committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    20cbfbf View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2017

  1. Added copyright information

    @irrenhaus3
    irrenhaus3 committed Jul 28, 2017
    Configuration menu
    Copy the full SHA
    65443db View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2017

  1. Adapt file extension only in single-export mode.

    @irrenhaus3
    irrenhaus3 committed Aug 1, 2017
    Configuration menu
    Copy the full SHA
    d7ee49c View commit details
    Browse the repository at this point in the history

  2. Add 'flac' format info to --help and manpage

    @irrenhaus3
    irrenhaus3 committed Aug 1, 2017
    Configuration menu
    Copy the full SHA
    18cda1d View commit details
    Browse the repository at this point in the history

  3. Code style

    @irrenhaus3
    irrenhaus3 committed Aug 1, 2017
    Configuration menu
    Copy the full SHA
    597d947 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2017

  1. More code style

    @irrenhaus3
    irrenhaus3 committed Aug 2, 2017
    Configuration menu
    Copy the full SHA
    597bc8f View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2017

  1. CMakeLists says: FLAC's pretty OK.

    @irrenhaus3
    irrenhaus3 committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    2c3cb02 View commit details
    Browse the repository at this point in the history

  2. Yet more code style.

    @irrenhaus3
    irrenhaus3 committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    521c08c View commit details
    Browse the repository at this point in the history