"misc" view now shows the model state, of the track use of master pitch

[serdnab]

Fix for #2612.
When an already created instance of InstrumentTrackWindow is used, the master pitch GroupBox isn't refreshed.
Now, if this is the case, when modelChanged() is invoked, the refresh is done.

[PhysSong]

Good observation! I haven't tested it yet, but It should be work.

[gi0e5b06]

getPitchGroupBox() should be renamed pitchGroupBox(), according to Qt and Lmms coventions.
Use the read accessor and not directly the field:
m_miscView->getPitchGroupBox()->setModel(&m_track->m_useMasterPitchModel);
should be:
m_miscView->pitchGroupBox()->setModel(m_track.useMasterPitchModel());
wgich requires to have the models mapped as properties, like volume.

BTW, thanks for the fix. If you spend a bit more time on refactoring the models/properties for the Track class, that would be great.

[Umcaruje]

I tested this and it works like a charm 👍 But @gi0e5b06 is right it seems inconsistent with the rest of the software so that'd need to change before a merge.

[PhysSong]

I think @gi0e5b06 is right, too.

getPitchGroupBox() should be renamed pitchGroupBox()

Yes, it's our convention.

Use the read accessor and not directly the field

It is recommended, but I think it's not necessary.

[serdnab]

getPitchGroupBox() should be renamed pitchGroupBox()

Yes, it's our convention.

Addressed

[zonkmachine]

Lower case here: PitchGroupBox() -> pitchGroupBox()

[PhysSong]

@serdnab This is our convention, too.

[PhysSong]

@serdnab?

[serdnab]

Done

[zonkmachine]

Tested! This fixes the issue.
Merge?