Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable HiDPI Scaling (Qt 5.6+ only) [stable-1.2] #3814

Merged
merged 3 commits into from Sep 20, 2017
Merged

Enable HiDPI Scaling (Qt 5.6+ only) [stable-1.2] #3814

merged 3 commits into from Sep 20, 2017

Conversation

ghost
Copy link

@ghost ghost commented Sep 19, 2017

This pull request is based on the stable-1.2 branch. Hopefully it will solve the long-standing UI scaling issue of LMMS. Tested on Ubuntu 16.04 via an AppImage.

@ghost ghost mentioned this pull request Sep 19, 2017
@tresf
Copy link
Member

tresf commented Sep 19, 2017

@flynn16 thanks for rebasing this against stable-1.2. Before this is merged, I think we owe it to the project to also test this on MacOS.

The code is:

<key>NSPrincipalClass</key>
<string>NSApplication</string>
<key>NSHighResolutionCapable</key>
<string>True</string>

The file it will eventually reside in is here:
https:/LMMS/lmms/blob/stable-1.2/cmake/apple/lmms.plist.in

Does anyone subscribed to the project have a Mac with a retina display that can test out the plist option? They would need to compile from this PR.

@ghost ghost mentioned this pull request Sep 19, 2017
3 tasks
@lukas-w
Copy link
Member

lukas-w commented Sep 19, 2017

@tresf I dont't see any difference between stable-1.2 and this branch with Qt 5.9.1. The UI is scaled properly in both cases.

@tresf
Copy link
Member

tresf commented Sep 19, 2017

@lukas-w Thanks. Do you have a retina display? If Qt is already scaling on retina, we'll keep the XML changes to be consistent with the official Qt documentation and just not make it a requirement before merging.

@ghost
Copy link
Author

ghost commented Sep 20, 2017

One more problem, the PPA used for cross compiling contains an old Qt 5. Perhaps someone should contact the PPA maintainer or build Qt 5.9 manually.

@tresf
Copy link
Member

tresf commented Sep 20, 2017

Perhaps someone should contact the PPA maintainer or build Qt 5.9 manually.

Thanks for the recommendation. His name is @tobydox and yes he's aware and working on updating the repos. They'll be under a 16.04 repo moving forward but can be safely force-installed onto 14.04 in Travis-CI.

If a new Qt build for Windows fixes the scaling issues there too, we can remove our hack which forces the exact opposite.

@lukas-w
Copy link
Member

lukas-w commented Sep 20, 2017

Do you have a retina display?

Yes. Most icons also appear pixelated due to upscaling, just like in the sreenshot in #2510 (comment).

@tresf
Copy link
Member

tresf commented Sep 20, 2017

Thanks for the feedback. Merging. This is a small commit, so it's easy to revert if it causes more issues down the road.

@tresf tresf merged commit 8a39302 into LMMS:stable-1.2 Sep 20, 2017
tresf added a commit to tresf/lmms that referenced this pull request Sep 20, 2017
@ghost ghost deleted the patch-2 branch September 27, 2017 04:07
@Redsandro
Copy link

I've just downloaded the AppImage version for Linux, so I have 1.2.0-rc5 (Linux/x86_64, Qt 5.9.2, GCC 4.8.4). However, everything is still microsized. Am I missing some setting to enable the scaling?

@ghost
Copy link
Author

ghost commented Apr 28, 2018 via email

@Redsandro
Copy link

@flynn16 thank you. The interface indeed scales nicely this way.

However, some fonts (menu, instrument panel) stay small while others (track titles) scale properly. Is there a setting for this I have missed?

image

sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Enables HiDPI Scaling in GuiApplication.cpp, environmental variable and mac manifest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants