Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes copy of non selected TCOs in Songeditor by Ctrl + dragging #3988

Closed
wants to merge 1 commit into from

Conversation

BaraMGB
Copy link
Contributor

@BaraMGB BaraMGB commented Nov 19, 2017

Fixes #3487 (comment)

copy of non selected TCOs by Ctrl and dragging now works again.

@PhysSong
Copy link
Member

Well, I think reverting unintended changes in #3487 will be better. #3487 reverted some changes in #3649, so I think they should be re-reverted.
I found some more bugs:

  • If I copy a TCO using drag&drop after dragging another TCO, a text float will show up at weird position.
  • Currently sample TCOs are resizable only in song editor. If I put mouse cursor on the left border of a sample TCO in BB editor, the cursor will change its shape as if the TCO is resizable.

@PhysSong
Copy link
Member

@BaraMGB Is it okay to open a PR which supersedes this if available? I have a fix for them.

@BaraMGB
Copy link
Contributor Author

BaraMGB commented Nov 23, 2017

Yes of course. I'm a little bit short on time.

@BaraMGB
Copy link
Contributor Author

BaraMGB commented Nov 28, 2017

Superseded by #4008

closed

@BaraMGB BaraMGB closed this Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants