-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't restore audio device during exporting #4083
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -77,7 +77,6 @@ ProjectRenderer::ProjectRenderer( const Mixer::qualitySettings & qualitySettings | |
QThread( Engine::mixer() ), | ||
m_fileDev( NULL ), | ||
m_qualitySettings( qualitySettings ), | ||
m_oldQualitySettings( Engine::mixer()->currentQualitySettings() ), | ||
m_progress( 0 ), | ||
m_abort( false ) | ||
{ | ||
|
@@ -103,8 +102,6 @@ ProjectRenderer::ProjectRenderer( const Mixer::qualitySettings & qualitySettings | |
|
||
ProjectRenderer::~ProjectRenderer() | ||
{ | ||
Engine::mixer()->restoreAudioDevice(); // also deletes audio-dev | ||
Engine::mixer()->changeQuality( m_oldQualitySettings ); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Make sure #3680 still works. If these test projects renders, as instructed, it's a 'go' from me. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @zonkmachine I'm pretty sure #3680 will still work because There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @zonkmachine Tested. It still works! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK. I think you should merge. |
||
} | ||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've included this check, but looks redundant. Maybe removing is better?