Phrygolydian to phrygian #4223
Merged
Phrygolydian to phrygian #4223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zonkmachine
requested changes
Mar 6, 2018
src/core/InstrumentFunctions.cpp
Outdated
| @@ -125,7 +125,7 @@ InstrumentFunctionNoteStacking::ChordTable::Init InstrumentFunctionNoteStacking: | |||
| { QT_TRANSLATE_NOOP( "InstrumentFunctionNoteStacking", "Neopolitan minor" ), { 0, 1, 3, 5, 7, 8, 11, -1 } }, | |||
| { QT_TRANSLATE_NOOP( "InstrumentFunctionNoteStacking", "Hungarian minor" ), { 0, 2, 3, 6, 7, 8, 11, -1 } }, | |||
| { QT_TRANSLATE_NOOP( "InstrumentFunctionNoteStacking", "Dorian" ), { 0, 2, 3, 5, 7, 9, 10, -1 } }, | |||
| { QT_TRANSLATE_NOOP( "InstrumentFunctionNoteStacking", "Phrygolydian" ), { 0, 1, 3, 5, 7, 8, 10, -1 } }, | |||
| { QT_TRANSLATE_NOOP( "InstrumentFunctionNoteStacking", "Phygrian" ), { 0, 1, 3, 5, 7, 8, 10, -1 } }, | |||
There was a problem hiding this comment.
-
Phygrian -> Phrygian
-
This is actually the only change that should be done. The locale files are updated automatically via the transifex platform so this is actually a one-line job. Please revert the locale file changes.
There was a problem hiding this comment.
Phrygian is still misspelled.
You got the geek part right, but I'm not the one who spot this. 😉 |
zonkmachine
requested changes
Mar 6, 2018
| ( tempoSyncKnob::tempoSyncMode ) _this.attribute( | ||
| "arpsyncmode" ).toInt() ); | ||
| }*/ | ||
|
|
||
| m_arpModeModel.loadSettings( _this, "arpmode" ); | ||
| } | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
What does No.4 spaces mean?
There was a problem hiding this comment.
It means I was somewhere else in the code... Sorry!
Gosh that word is so confusing to spell
|
I'll double check and then squash/merge this as one commit. |
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4219 which was a spelling error within the interface.
I would like to take a small moment to give thanks to all music theory geeks for catching this error ^_^ Espeically zonkmachine.