Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better behavior when left-clicking a TCO #4290

Merged
merged 1 commit into from
Apr 11, 2018
Merged

Better behavior when left-clicking a TCO #4290

merged 1 commit into from
Apr 11, 2018

Conversation

Sawuare
Copy link
Member

@Sawuare Sawuare commented Apr 9, 2018

Instead of calling MouseMoveEvent(), the TCO's "text float" text and position are updated.
This prevents left-clicking the right edge of a resizable TCO from decreasing its size.

Also, removed an unused variable: m_oldTime

Instead of calling MouseMoveEvent(), the TCO's text and position are updated.
This prevents left-clicking the right of a TCO from decreasing its size.

Also, removed an unused variable: m_oldTime
@zonkmachine
Copy link
Member

This prevents left-clicking the right of a TCO from decreasing its size.

Yeah, I don't think I've seen this reported before but I can confirm the issue. You basically end up nudging the TCO a bit to the left sometimes when grabbing the edge. Fix confirmed.
It's not really an enhancement but a ux/bug and I think it's correct to address this in 1.2 .

@zonkmachine zonkmachine added ux and removed enhancement labels Apr 9, 2018
@musikBear
Copy link

I feel that it can be a tad difficult to 'grab' the move-handle on notes <= 1/16. I quite often resize the note instead. Its very simple to 'fix'. Setting magnification to 200% let me grab notes easy -Will this fix influence 'grabbing' of <= 1/16 notes?

@zonkmachine
Copy link
Member

I feel that it can be a tad difficult to 'grab' the move-handle on notes <= 1/16

OT. This PR is about TCO's in the Song Editor and not about grabbing notes.

@musikBear
Copy link

OT. This PR is about TCO's in the Song Editor and not about grabbing notes.

ooops.. but Note-TCO cant change size(?) so AUT and B&B..
I will write a ticket for the note-grab

@Sawuare Sawuare merged commit e554a4c into LMMS:stable-1.2 Apr 11, 2018
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Instead of calling MouseMoveEvent(), the TCO's "text float" text and position are updated.
This prevents left-clicking the right edge of a resizable TCO from decreasing its size.

Also, removed an unused variable: m_oldTime
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants