Fix LADSPA automation disconnects on export (LMMS#4781) #4972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mine! 😄 |
There was a problem hiding this comment.
Stylistically OK.
Can't cause regressions. Also heavily tested by @T0NIT0RMX .
Functionally OK and reasonable. Thanks to @PhysSong for the fix proposal and @DomClark for explanations about the Journal IDs.
@T0NIT0RMX If you fix the comment, I'll merge this.
Co-Authored-By: Johannes Lorenz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the explainations of @PhysSong about how to solve the issue I fixed the problem on my side !
I did it last month, I use LMMS everyday and can't see any issues with it, so by request of @JohannesLorenz I'm making this PR.
Hopefully it will help !
PD : I made sure to remplace the 4 spaces with 1 tab, so it should be alright now !