Rubberband fix for selecting large area in Songeditor #5003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaraMGB
added
the
needs code review
If you want to test more, we can include this in 1.2.1 instead of 1.2.0. |
PhysSong
reviewed
Jun 6, 2019
|
Thank you for your time. |
Reflexe
requested changes
Jun 8, 2019
Reflexe
approved these changes
Jun 12, 2019
PhysSong
reviewed
Jun 12, 2019
|
I found that lassoing with Shift+drag on the timeline is broken. @BaraMGB Could you look into it? |
|
@PhysSong Thank you. I'll look into it. 👍 |
PhysSong
reviewed
Jun 15, 2019
|
@PhysSong can this be merged or do you want to test it more? |
PhysSong
reviewed
Jun 22, 2019
|
The functionality looks okay, but I think we have some time to test this more because this PR targets the stable branch. |
BaraMGB
added
needs testing
|
@PhysSong Do you think, this should go into 1.2.1? |
|
I think it's okay to merge this now. As far as I tested, this won't bring any serious regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4974
scrolling and zooming while selecting an area works now. But with 180 additions and 70 deletions this is a big bug fix. I don't know if this should be merged so close before releasing 1.2.