Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set focus on Automation Editor editor instead of window. #5170

Merged
merged 1 commit into from Oct 1, 2019
Merged

Set focus on Automation Editor editor instead of window. #5170

merged 1 commit into from Oct 1, 2019

Conversation

ghost
Copy link

@ghost ghost commented Sep 4, 2019

Set focus on Automation Editor editor instead of window so keyPressEvent's can be processed. This makes shortcuts work without manually have to click somewhere in the grey area of the editor itself.

@ghost
Copy link
Author

ghost commented Sep 6, 2019

@PhysSong, what about moving keyPressEvent to AutomationEditorWindow? Even with this change when the editor has focus and you click the window title it loses focus and thus still doesn't process keyPressEvent's.

@PhysSong
Copy link
Member

PhysSong commented Sep 6, 2019

It seems like PianoRollWindow::focusInEvent() gives the focus to its editor as well. We may add something like this to AutomationEditorWindow or even Editor.

@ghost
Copy link
Author

ghost commented Sep 8, 2019

Yes that did it! It now always processes the Editor it's keyPressEvent's :-)

…ent's can be processed. (Make shortcuts work on open)
@PhysSong PhysSong added needs testing This pull request needs more testing and removed needs testing This pull request needs more testing labels Oct 1, 2019
@PhysSong PhysSong merged commit 5132d91 into LMMS:master Oct 1, 2019
Veratil added a commit to Veratil/lmms that referenced this pull request Oct 6, 2019
Veratil added a commit to Veratil/lmms that referenced this pull request Oct 6, 2019
zonkmachine pushed a commit that referenced this pull request Oct 7, 2019
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
)

This will make shortcuts work on opening the editor.
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant