Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation Editor point fine tuning with double click #5292

Closed
wants to merge 1 commit into from

Conversation

tecknixia
Copy link
Contributor

@tecknixia tecknixia commented Oct 31, 2019

Related to issue #5225 and old PR #5232 (closed)

Allows user to double click an automation point in the Automation Editor, and enter new number to adjust the y level for that point. It also improves mouse cursor interaction with the point, and shows the point's Y level when mouse cursor is over a point.

This PR involves the creation of doubleClickEvent, creation of variable m_pointYLevel, and the use of mouseMoveEvent and drawCross.

  • A variable, m_pointYLevel is created and used to hold a point's Y level position.
  • The value of m_pointYLevel is set when the mouse moves over a point.
  • The value of m_pointYLevel is used when opening an input dialog box, for the current value.
  • If the mouse moves away from a point, the value of m_pointYLevel returns to 0.
  • When the value of m_pointYLevel is 0, the tool tip in drawCross displays the Y level position of the mouse.
  • When the value of m_pointYLevel is greater than 0, the tool tip in drawCross displays the point's Y level position.

@LmmsBot
Copy link

LmmsBot commented Oct 31, 2019

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

Windows

macOS

🤖
{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://5093-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.569-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/5093?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://5092-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.569-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/5092?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://5090-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.569-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/5090?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/k5m67s4pud0h95eg/artifacts/build/lmms-1.2.1-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/28696442"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/e5en8sjfpe06gjkv/artifacts/build/lmms-1.2.1-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/28696442"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://5094-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.569-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/5094?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "cf50b86bd1607b3988899292e62e2effdab4bc41"}

@tecknixia tecknixia force-pushed the autoDBClick branch 3 times, most recently from 8c0ed95 to 11872a7 Compare November 7, 2019 06:26
@zonkmachine zonkmachine added needs code review A functional code review is currently required for this PR needs style review A style review is currently required for this PR needs testing This pull request needs more testing labels Apr 9, 2020
@tecknixia
Copy link
Contributor Author

@russiankumar
#5592
Waiting for reviews and testing.

@superpaik
Copy link
Contributor

@tecknixia
Hi, Sorry I'm new in the testing team. Is this PR ready to test? The builds done by the bot are no longer availaible.
I've downloaded the PR from github and build it locally. Is that the last code available for this feature?
First test is ok. Minor issues:

  • the popup window show 0,000 as value. I think it should be great to have the actual value of the point.
  • I'm using a spanish version of windows. So if I enter 100,89 it works ok, but if I do 100.89 (with dot) it translate into 10089. Maybe is related to local version.

IanCaio pushed a commit to IanCaio/lmms that referenced this pull request Dec 26, 2020
	Implements a way to fine tune a node's inValue/outValue by
double clicking the node on the AutomationEditor.
	This is an adaptation of PR LMMS#5292 for the new AutomationEditor
code which is being changed by PR LMMS#5712, keeping the original
authorship.
@IanCaio
Copy link
Contributor

IanCaio commented Dec 26, 2020

I just adapted this PR to have #5712 as a base branch, since it changes quite a lot of the AutomationEditor/AutomationPattern and some tweaking would be necessary to make this PR compatible with it. I kept the original authorship by commiting with --author="tecknixia" and it's ready to be submitted as a separate PR once the changes from the AutomationEditor are merged. Once it's submitted this one can be closed!

IanCaio/lmms@feature/automationProgression...IanCaio:feature/automationProgressionFineTuning

@IanCaio
Copy link
Contributor

IanCaio commented Mar 28, 2021

Closing this as #5923 which rewrote this over the new AutomationPattern framework was already merged.

@IanCaio IanCaio closed this Mar 28, 2021
devnexen pushed a commit to devnexen/lmms that referenced this pull request Apr 10, 2021
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs code review A functional code review is currently required for this PR needs style review A style review is currently required for this PR needs testing This pull request needs more testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants