Bias dropped clip position backwards #5401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Windows
macOS
🤖{"platform_name_to_artifacts": {"Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://5761-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.584-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/5761?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://5759-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.584-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/5759?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/ebpiy2dfk9r08b4w/artifacts/build/lmms-1.2.1-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/30996979"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/w8onek4t1e8xtqiy/artifacts/build/lmms-1.2.1-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/30996979"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://5760-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.584-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/5760?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "bbb3624399e2683864e34c51f7d5f00968f25685"} |
|
The code looks good. Please feel free to merge it if you think we should revert to the old snapping behavior(no objections from me, FYI). |
|
Thanks for the review! :) |
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Bias dropped clip position backwards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the drop behavior from before #4973, as users expect clips to start on the bar they hover over, not on the bar whose start is closer to the cursor. Scales with snap size as well, so it drops onto the half-bar hovered over rather than the half-bar whose start is closer to the cursor, etc.
Closes #5393