Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Sid to submodule #5724

Merged
merged 5 commits into from
Oct 30, 2020
Merged

Switch Sid to submodule #5724

merged 5 commits into from
Oct 30, 2020

Conversation

tresf
Copy link
Member

@tresf tresf commented Oct 21, 2020

Switches Sid to a resid submodule kindly maintained by @simonowen.

  • Rename code occurrences of cSID() to SID()
  • Parse VERSION from resid/CMakeLists.txt
  • Switch plugin to TitleCase

Related #3963

@LmmsBot
Copy link

LmmsBot commented Oct 21, 2020

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

Windows

macOS

🤖
{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://9769-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-741%2Bg46ea10e-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/9769?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://9766-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-741%2Bg46ea10eec-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/9766?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://9767-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-741%2Bg46ea10eec-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/9767?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/64viq7axg8a3dplm/artifacts/build/lmms-1.2.2-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/35880570"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/a2snm646oetduf08/artifacts/build/lmms-1.2.2-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/35880570"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://9765-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-741%2Bg46ea10eec-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/9765?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "255efdf7263bc19483b4120f7218737cba772da2"}

@tresf tresf changed the title Switch SID to submodule Switch Sid to submodule Oct 21, 2020
@tresf tresf mentioned this pull request Oct 21, 2020
@tresf tresf merged commit 9d104b2 into LMMS:master Oct 30, 2020
@tresf tresf deleted the sid branch October 30, 2020 17:34
IanCaio pushed a commit to IanCaio/lmms that referenced this pull request Mar 28, 2021
Also refactors to TitleCase, uses newer SID namespace
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Also refactors to TitleCase, uses newer SID namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants