fix compilation with 'AUDIO_PORT_SUPPORT'

[fogti]

As this only affects the JACK audio backend, I think this PR won't be affected by #5592.
I added a check for jack_port_set_name (deprecated) vs jack_port_rename.
see also hydrogen-music/hydrogen#365 (2016 !)

[LmmsBot]

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

• Linux (AppImage): lmms-1.3.0-alpha.1.51%2Bg8e00c73-linux-x86_64.AppImage (build link)

Windows

• Windows 32-bit: lmms-1.3.0-alpha.1.51%2Bg8e00c7364-mingw-win32.exe (build link)
• Windows 64-bit: lmms-1.3.0-alpha.1.51%2Bg8e00c7364-mingw-win64.exe (build link)
• Windows 32-bit: lmms-1.3.0-alpha-msvc2017-win32.exe (build link)
• Windows 64-bit: lmms-1.3.0-alpha-msvc2017-win64.exe (build link)

🤖

{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://11620-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.51%2Bg8e00c73-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/11620?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://11623-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.51%2Bg8e00c7364-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/11623?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://11622-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.51%2Bg8e00c7364-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/11622?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/bdrswm7cc654vy5n/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/36827330"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/205b9hleon47wakr/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/36827330"}]}, "commit_sha": "307636099d8f819b60eb6df2167ecd6f37d77e96"}

[PhysSong]

Thanks for the note! It seems like jack_port_rename was introduced in JACK1 0.125.0 and JACK2 1.9.11, but Ubuntu 16.04 still ships with the version of JACK1 without the function while JACK2 is okay.
When using weakjack(enabled by default), it dispatches calls to jack_port_rename using jack_port_set_name internally on runtime, so it's always okay when using weakjack.

If you're interested in adding the checks to CMakeLists.txt, I can help you. Otherwise, I will add relevant changes to this.

[fogti]

I think I should add the appropriate check_library_exists check to the IF(WANT_JACK) { IF(WANT_WEAKCHECK) ... ELSE ... [here] } section in the /CMakeLists.txt file. The lines added would be

SET(CMAKE_REQUIRED_LIBRARIES_BACKUP "${CMAKE_REQUIRED_LIBRARIES}")
SET(CMAKE_REQUIRED_LIBRARIES "${JACK_LIBRARIES}")
CHECK_LIBRARY_EXISTS(jack jack_port_rename "" HAVE_JACK_PORT_RENAME)
SET(CMAKE_REQUIRED_LIBRARIES "${CMAKE_REQUIRED_LIBRARIES_BACKUP}")
UNSET(CMAKE_REQUIRED_LIBRARIES_BACKUP)

I'm unsure in which header file or such I should place the following line, if at all (I haven't found an appropriate configure_file statement in any CMakeLists.txt)

#cmakedefine HAVE_JACK_PORT_RENAME

[fogti]

Oh, the macos CI is broken...