-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Qt layouts for mixer channels #6591
Commits on Dec 18, 2022
-
Remove extra transparency in send/receive arrows
The extra transparency was conflicting with the positioning of the arrows in the layout
Configuration menu - View commit details
-
Copy full SHA for b447484 - Browse repository at this point
Copy the full SHA b447484View commit details -
Begin reimplementing MixerChannelView
MixerChannelView is now a combination of the MixerLine with the previous MixerChannelView
Configuration menu - View commit details
-
Copy full SHA for fb94805 - Browse repository at this point
Copy the full SHA fb94805View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e5135f - Browse repository at this point
Copy the full SHA 4e5135fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b71b6a - Browse repository at this point
Copy the full SHA 3b71b6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e5b81d2 - Browse repository at this point
Copy the full SHA e5b81d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6511771 - Browse repository at this point
Copy the full SHA 6511771View commit details -
Change MixerView.h to use MixerChannelView
Change MixerView.h to use MixerChannelView rather than MixerLine Also do some cleanup, such as removing an unused forward declaration of QButtonGroup
Configuration menu - View commit details
-
Copy full SHA for 28c8ab2 - Browse repository at this point
Copy the full SHA 28c8ab2View commit details -
+ Set height of sizeHint() using MIXER_CHANNEL_HEIGHT (287)
Configuration menu - View commit details
-
Copy full SHA for 48a5d4d - Browse repository at this point
Copy the full SHA 48a5d4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ba600f - Browse repository at this point
Copy the full SHA 4ba600fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1908231 - Browse repository at this point
Copy the full SHA 1908231View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcfb14c - Browse repository at this point
Copy the full SHA dcfb14cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 539c2cf - Browse repository at this point
Copy the full SHA 539c2cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for e3be7c8 - Browse repository at this point
Copy the full SHA e3be7c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for beb3d8e - Browse repository at this point
Copy the full SHA beb3d8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for dfe0561 - Browse repository at this point
Copy the full SHA dfe0561View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63d5989 - Browse repository at this point
Copy the full SHA 63d5989View commit details -
Remove places where MixerChannelView is being deleted
Before, MixerChannelView was not inherited by QWidget, meaning it could not have a parent and had to be deleted when necessary. Since the MixerView owns the new MixerChannelView, this is no longer necessary.
Configuration menu - View commit details
-
Copy full SHA for 1905431 - Browse repository at this point
Copy the full SHA 1905431View commit details -
Replace MixerLine with MixerChannelView
- Include MixerChannelView in MixerView
Configuration menu - View commit details
-
Copy full SHA for f915d3f - Browse repository at this point
Copy the full SHA f915d3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b83b510 - Browse repository at this point
Copy the full SHA b83b510View commit details -
Configuration menu - View commit details
-
Copy full SHA for fed3389 - Browse repository at this point
Copy the full SHA fed3389View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6fcee5 - Browse repository at this point
Copy the full SHA c6fcee5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 135c16c - Browse repository at this point
Copy the full SHA 135c16cView commit details -
Add QColor properties from style
- Set the Qt::WA_StyledBackground attribute on
Configuration menu - View commit details
-
Copy full SHA for 4eddae6 - Browse repository at this point
Copy the full SHA 4eddae6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 937c4a1 - Browse repository at this point
Copy the full SHA 937c4a1View commit details -
- Change nullptr to this for certain widgets - Some custom widgets may expect there to be a parent - Add spacing in channel layout - Increase size of mixer channel
Configuration menu - View commit details
-
Copy full SHA for abb4520 - Browse repository at this point
Copy the full SHA abb4520View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9b894e - Browse repository at this point
Copy the full SHA b9b894eView commit details
Commits on Dec 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 38d176e - Browse repository at this point
Copy the full SHA 38d176eView commit details -
Implement send/receive arrow toggling
- Make maxTextHeight constexpr in elideName - Remove background changing on mouse press (is now handled in paintEvent)
Configuration menu - View commit details
-
Copy full SHA for 484fe76 - Browse repository at this point
Copy the full SHA 484fe76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b3dba2 - Browse repository at this point
Copy the full SHA 4b3dba2View commit details -
Configuration menu - View commit details
-
Copy full SHA for cfad01e - Browse repository at this point
Copy the full SHA cfad01eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12e5759 - Browse repository at this point
Copy the full SHA 12e5759View commit details -
Not sure if that connection with the mute model was needed, but removing it did not seem to introduce any issues.
Configuration menu - View commit details
-
Copy full SHA for d2a3e5f - Browse repository at this point
Copy the full SHA d2a3e5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7dec220 - Browse repository at this point
Copy the full SHA 7dec220View commit details -
Configuration menu - View commit details
-
Copy full SHA for 354fd2a - Browse repository at this point
Copy the full SHA 354fd2aView commit details
Commits on Dec 22, 2022
-
+ Make m_renameLineEdit transparent + Retain size when LCD is hidden + Remove stretch after renameLineEdit in layout
Configuration menu - View commit details
-
Copy full SHA for a51855c - Browse repository at this point
Copy the full SHA a51855cView commit details
Commits on Dec 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0e92d4d - Browse repository at this point
Copy the full SHA 0e92d4dView commit details
Commits on Dec 24, 2022
-
Make m_renameLineEdit read only
+ Transpose m_renameLineEditView rectangle (with 5px offset)
Configuration menu - View commit details
-
Copy full SHA for 51bb83f - Browse repository at this point
Copy the full SHA 51bb83fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a451a7 - Browse repository at this point
Copy the full SHA 2a451a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3eac413 - Browse repository at this point
Copy the full SHA 3eac413View commit details -
Use sizeHint for mixerChannelSize
+ Leave auto fill background to false in MixerChannelView + Only set width for EffectRackView
Configuration menu - View commit details
-
Copy full SHA for ff7965a - Browse repository at this point
Copy the full SHA ff7965aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ac835dc - Browse repository at this point
Copy the full SHA ac835dcView commit details
Commits on Dec 27, 2023
-
Merge master and fix the build
Finxing the build mostly includes applying several of the changes that have been made to `MixerLine` in the meantime to `MixerChannelView`. The relevant commits are: * Classier enums: f102777 * Keep master bus color on FX Mixer when switching project: 609c008 * Use std::optional for colour interfaces and storage: dc8c49a Commit aa050ae also made changes to `MixerLine`. These have not been applied as they do not seem to be relevant to `MixerChannelView`. `InstrumentTrackView` and `SampleTrackView` had references to `MixerLineLcdSpinBox`. These have been adjusted to `MixerChannelLcdSpinBox` in the header files and the implementation files. Conflicts: * include/MixerChannelLcdSpinBox.h * include/MixerLine.h * include/SampleTrackWindow.h * src/gui/MixerLine.cpp * src/gui/MixerView.cpp * src/gui/SendButtonIndicator.cpp
Configuration menu - View commit details
-
Copy full SHA for d6a0f4d - Browse repository at this point
Copy the full SHA d6a0f4dView commit details -
Move solo and mute closer to each other
Move the solo and mute buttons closer to each other in the mixer channels. Technically this is accomplished by putting them into their own layout with minimal margins and spacing.
Configuration menu - View commit details
-
Copy full SHA for 27f91c3 - Browse repository at this point
Copy the full SHA 27f91c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29e4cfe - Browse repository at this point
Copy the full SHA 29e4cfeView commit details
Commits on Dec 29, 2023
-
Mostly whitespace and formatting changes: remove tabs, remove spaces in parameter lists, remove underscores from parameter names. Some lines have been shortened by introducing intermediate variables, e.g. in `MixerChannelView`. `MixerView` has many changes but only related to whitespace. Spaces have been introduced for if and for statements. Whitespace at round braces has been removed everywhere in the implementation file even if a line was not touched by the intial changes. Remove duplicate forward declaration of `MixerChannelView`.
Configuration menu - View commit details
-
Copy full SHA for f32d9ce - Browse repository at this point
Copy the full SHA f32d9ceView commit details -
Adjust parameter order in MixerChannelView's constructor
Make the parent `QWidget` the first parameter as it is a Qt convention. The default parameter had to be removed due to this.
Configuration menu - View commit details
-
Copy full SHA for 6950998 - Browse repository at this point
Copy the full SHA 6950998View commit details -
Move styling of rename line edit into style sheets
Move the style of the `QGraphicsView` for the rename line edit from the code into the style sheets of the default and classic theme.
Configuration menu - View commit details
-
Copy full SHA for 1d3ee18 - Browse repository at this point
Copy the full SHA 1d3ee18View commit details
Commits on Dec 30, 2023
-
Fix spaces between types and references/pointers, e.g. use `const QBrush& c` instead of `const QBrush & c`. Remove underscores from parameter names. Remove spaces near parentheses. Replace tabs with spaces. Introduce intermediate variable to resolve "hanging" + operator. Replace the connection for the periodic fader updates with one that uses function pointers instead of `SIGNAL` and `SLOT`.
Configuration menu - View commit details
-
Copy full SHA for 92878ce - Browse repository at this point
Copy the full SHA 92878ceView commit details