Add peak indicators #7295
Merged
Add peak indicators #7295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add peak indicators to the mixer strips. They show the maximum peak value that was observed and can be reset by clicking on them. The implementation works via a signal/slot mechanism. The `Fader` class has a new signal `peakChanged` which reports peak values as amplifications. A new class `PeakIndicator` is added which has a slot `updatePeak` which is connected to the new signal in `Fader`. The `PeakIndicator` inherits from `QLabel` and mainly deals with updating the label text from the current peak value. Add a `PeakIndicator` instance to `MixerChannelView`. Add a `reset` method to `MixerChannelView` so that the mixer channel can be reset on the loading of new projects, etc. The current implementation resets the peak indicator back to -inf dbFS. The `reset` method is called in `MixerView::clear`. Remove the clamping in `Fader::setPeak` so that all peaks are reported. Emit the new signal if the peak changes.
Closed
Closed
…ixerChannels Conflicts: * src/gui/MixerChannelView.cpp
Use `nullptr` instead of `0`. Use `emit` macro.
zonkmachine
approved these changes
Jun 1, 2024
There was a problem hiding this comment.
Tests fine. LGTM!
One thought. I'm guessing that there will be some complaints regarding the size of the indicator numbers and now that the mixer can expand, maybe it could be good (in a later PR...) to let it expand a bit sideways too and give room for larger numbers/text.
Yes, for larger fonts the mixer strips would have to be able to expand to the side as well. This is how small values currently look:
If the size of the font is increased the labels will clip if they do not expand sideways. |
Closed
Rossmaxx
pushed a commit
to Rossmaxx/lmms
that referenced
this pull request
Jun 15, 2024
Add peak indicators to the mixer strips. They show the maximum peak value that was observed and can be reset by clicking on them. ## Implementation details The implementation works via a signal/slot mechanism. The `Fader` class has a new signal `peakChanged` which reports peak values as amplifications. A new class `PeakIndicator` is added which has a slot `updatePeak` which is connected to the new signal in `Fader`. The `PeakIndicator` inherits from `QLabel` and mainly deals with updating the label text from the current peak value. Add a `PeakIndicator` instance to `MixerChannelView`. Add a `reset` method to `MixerChannelView` so that the mixer channel can be reset on the loading of new projects, etc. The current implementation resets the peak indicator back to -inf dbFS. The `reset` method is called in `MixerView::clear`. Remove the clamping in `Fader::setPeak` so that all peaks are reported. Emit the new signal if the peak changes.
Rossmaxx
pushed a commit
to Reflexe/lmms
that referenced
this pull request
Jul 16, 2024
Add peak indicators to the mixer strips. They show the maximum peak value that was observed and can be reset by clicking on them. ## Implementation details The implementation works via a signal/slot mechanism. The `Fader` class has a new signal `peakChanged` which reports peak values as amplifications. A new class `PeakIndicator` is added which has a slot `updatePeak` which is connected to the new signal in `Fader`. The `PeakIndicator` inherits from `QLabel` and mainly deals with updating the label text from the current peak value. Add a `PeakIndicator` instance to `MixerChannelView`. Add a `reset` method to `MixerChannelView` so that the mixer channel can be reset on the loading of new projects, etc. The current implementation resets the peak indicator back to -inf dbFS. The `reset` method is called in `MixerView::clear`. Remove the clamping in `Fader::setPeak` so that all peaks are reported. Emit the new signal if the peak changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add peak indicators to the mixer strips. They show the maximum peak value that was observed and can be reset by clicking on them.
Implementation details
The implementation works via a signal/slot mechanism. The
Faderclass has a new signalpeakChangedwhich reports peak values as amplifications. A new classPeakIndicatoris added which has a slotupdatePeakwhich is connected to the new signal inFader.The
PeakIndicatorinherits fromQLabeland mainly deals with updating the label text from the current peak value.Add a
PeakIndicatorinstance toMixerChannelView. Add aresetmethod toMixerChannelViewso that the mixer channel can be reset on the loading of new projects, etc. The current implementation resets the peak indicator back to -inf dbFS. Theresetmethod is called inMixerView::clear.Remove the clamping in
Fader::setPeakso that all peaks are reported. Emit the new signal if the peak changes.