fix(logging): correct error logging to display error message #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Taylor Webber <[email protected]>
Signed-off-by: Taylor Webber <[email protected]>
|
@LanceMcCarthy could this get reviewed when you get a chance? |
|
I'll check it out today, thanks for grabbing the details. |
|
Thank you for @ mentioning me. I never got the original notification. I was shocked to see all the pending PRs. Your PR is merged now, but I'll be doing the rest of the dependabot items this morning, once that is done, I'll push out an update to v3 Worst-case scenario, if there's a breaking change in the upstream SDK update, I'll release a v4 and also backport your fixes to v3. |
|
@LumixximuL All set, Please let me know if you have any problems! |
|
Thanks so much @LanceMcCarthy !! |
LanceMcCarthy
added a commit
that referenced
this pull request
Feb 15, 2023
Stringifiy error output for better issue debugging. This is the same as #24
LanceMcCarthy
added a commit
that referenced
this pull request
Feb 15, 2023
* Add the new Github dynamic secrets provider example. * Stringify error output for better issue debugging. This is the same as #24 * Fix name of dynamic provider * Add more GitHub dynamic secrets test cases * Update examples with GitHub dynamic secrets provider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Taylor Webber [email protected]
Error message is not correctly being displayed on failure
AWS Producer error message
Dynamic Secret error message