generated from Leafwing-Studios/template-repo
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inputs serialization #620
Labels
enhancement
New feature or request
Milestone
Comments
Looks like the crate already uses https:/Gohla/serde_flexitos, we just need include an example for it. |
Adding a generic |
Another option would be consider enum dispatch. I.e. keep all the separation like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What problem does this solve?
I would like to be able to serialize inputs to a config file and deserialize it back. But there are a 2 problems:
InputMap
accept concrete type, not a fat pointer.What solution would you like?
Not exactly sure how to solve this...
For 1 we can use something like https:/dtolnay/erased-serde, but it require a separate crate for such a common use case is not very nice. It's also possible to use Bevy's reflection. But it requires manual ser/de implementation for user which is hard to write.
For 2 we can accept
Into<Box<dyn Trait>>
since all methods internally doBox::new
.[Optional] What alternatives have you considered?
Maybe using traits wasn't the right call... Maybe we could have better enums? Like keep all
insert
,insert_axislike
etc., but use enums instead of boxes.Related work
Caused by #534.
The text was updated successfully, but these errors were encountered: