Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting for NBGL on LNS, LNX and LNSP #123

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

xchapron-ledger
Copy link
Contributor

@xchapron-ledger xchapron-ledger commented Apr 26, 2024

Needs:

diff --git a/src/ragger/navigator/navigation_scenario.py b/src/ragger/navigator/navigation_scenario.py
index f903e97..d9548bb 100644
--- a/src/ragger/navigator/navigation_scenario.py
+++ b/src/ragger/navigator/navigation_scenario.py
@@ -18,7 +18,7 @@ class NavigationScenarioData:
     def __init__(self, device: str, use_case: UseCase, approve: bool):
         if device.startswith("nano"):
             self.navigation = NavInsID.RIGHT_CLICK
-            self.validation = [NavInsID.BOTH_CLICK]
+            self.validation = [NavInsID.BOTH_CLICK, NavInsID.BOTH_CLICK]
             self.pattern = "^Approve$" if approve else "^Reject$"
 
         elif device.startswith("stax") or device.startswith("flex"):

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.01%. Comparing base (1f92f77) to head (77fac20).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   83.01%   83.01%           
=======================================
  Files           3        3           
  Lines          53       53           
=======================================
  Hits           44       44           
  Misses          9        9           
Flag Coverage Δ
unittests 83.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xchapron-ledger xchapron-ledger force-pushed the xch/nbgl-lns branch 2 times, most recently from 77d90a6 to a14545b Compare April 30, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants