Add NBGL use cases (settings and choice) and NVM management #97

tdejoigny-ledger · 2023-10-10T16:58:18Z

Improve the settings use case in order to be able to use app settings parameters stored in NVM
and add a NBGL use case choice when a setting switch is toggled

… parameters stored in NVM and add a NBGL use case choice when a setting switch is toggled

codecov · 2023-10-10T16:59:38Z

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (159ed1f) 80.43% compared to head (d5f17d6) 80.43%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   80.43%   80.43%           
=======================================
  Files           3        3           
  Lines          46       46           
=======================================
  Hits           37       37           
  Misses          9        9

Flag	Coverage Δ
unittests	`80.43% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/globals.h

src/ui/menu_nbgl.c

xchapron-ledger

Shouldn't we expose it on BAGL too?

xchapron-ledger

What about implementation on BAGL? I'd say this could be interessting too?

src/app_main.c

tdejoigny-ledger · 2023-10-11T16:43:09Z

What about implementation on BAGL? I'd say this could be interessting too?

yes it could be, but it was not the initial target of this PR ;-)
could be done in a subsequent PR

Improve the settings use case in order to be able to use app settings…

8acc121

… parameters stored in NVM and add a NBGL use case choice when a setting switch is toggled