Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[add] ledger_app.toml C manifest #98

Merged
merged 1 commit into from
Nov 7, 2023
Merged

[add] ledger_app.toml C manifest #98

merged 1 commit into from
Nov 7, 2023

Conversation

lpascal-ledger
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c446173) 80.43% compared to head (bccfb4f) 80.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   80.43%   80.43%           
=======================================
  Files           3        3           
  Lines          46       46           
=======================================
  Hits           37       37           
  Misses          9        9           
Flag Coverage Δ
unittests 80.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ledger_app.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@xchapron-ledger xchapron-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say part of the objective here is to get rid of some specific settings everywhere.

Another one that is present at multiple location is the list of compatible devices, maybe we can add it there?

For the test part, I'm not sure, I think both @agrojean-ledger and @sgliner-ledger had some usage, and therefore could have needed fields here?
I'm thinking for example at the flags input argument of the reusable_build workflow.

@lpascal-ledger
Copy link
Contributor Author

lpascal-ledger commented Oct 13, 2023

@xchapron-ledger I'm creating an issue on the workflow repo as I feel it's the more relevant place for such discussion.

@lpascal-ledger lpascal-ledger marked this pull request as draft October 13, 2023 09:26
@agrojean-ledger
Copy link
Contributor

agrojean-ledger commented Oct 13, 2023

@lpascal-ledger @xchapron-ledger I guess we either need to change the name of this manifest file or we need to update how we detect rust apps in various scripts (I have deployer.py and the reusable workflows in mind) which just look for this ledger_app.toml

We could put a language field directly in the manifest for instance...

@lpascal-ledger
Copy link
Contributor Author

@agrojean-ledger see here for discussion.

ledger_app.toml Outdated Show resolved Hide resolved
@lpascal-ledger lpascal-ledger merged commit 4699479 into master Nov 7, 2023
39 checks passed
@lpascal-ledger lpascal-ledger deleted the lp/manifest branch November 7, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants