Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VG-11533 Remove keychain filtering when fetching operation #922

Merged
merged 7 commits into from
Dec 27, 2022
Merged

VG-11533 Remove keychain filtering when fetching operation #922

merged 7 commits into from
Dec 27, 2022

Conversation

BertrandD
Copy link
Contributor

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

jcoatelen-ledger
jcoatelen-ledger requested changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@jcoatelen-ledger jcoatelen-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes only, well done!

core/src/wallet/tezos/TezosLikeAccount.cpp Outdated Show resolved Hide resolved
core/src/wallet/ripple/RippleLikeAccount.cpp Outdated Show resolved Hide resolved
core/src/wallet/cosmos/CosmosLikeAccount.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

clang-tidy review says "All clean, LGTM! 👍"

@BertrandD BertrandD merged commit 4d48c99 into main Dec 27, 2022
@BertrandD BertrandD deleted the fix/remove_keychain_filtering branch December 27, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcoatelen-ledger jcoatelen-ledger jcoatelen-ledger approved these changes

@twilgenbus-ledger twilgenbus-ledger Awaiting requested review from twilgenbus-ledger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BertrandD @jcoatelen-ledger