Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ripple explorer (de)serialization issues #938

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

jcoatelen-ledger
Copy link
Contributor

@jcoatelen-ledger jcoatelen-ledger commented Jun 27, 2023

Fixes VSD-2389 and VSD-2405

Changes:

  • ledger_index_min is now returned as a integer object and not a string-integer ; the synchronization fails at fetching the account transactions. Fix: change ledger_index_min type from string to unsigned int64
  • Amount attribute is missing for AccountDelete tx type. Fix: parse DeliveredAmount, which is there for this tx type instead.

Note: I would not suggest to use delivered_amount which seems always returned because I don't know how the parsing would go for other tx types, e.g. if delivered_amount is always matching Amount (even if I suppose they will be always equal).

Results:
sync successful, no error at sync, correct amount saved in db
image

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@jcoatelen-ledger jcoatelen-ledger changed the title Fix-ripple-explorer-parsing Fix ripple explorer (de)serialization issues Jun 27, 2023
@jcoatelen-ledger jcoatelen-ledger marked this pull request as ready for review June 27, 2023 14:21
Copy link
Contributor

@BertrandD BertrandD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming it has been tested manually

@jcoatelen-ledger jcoatelen-ledger merged commit a0ff9a8 into main Jun 28, 2023
@jcoatelen-ledger jcoatelen-ledger deleted the fix-ripple-explorer-parsing branch June 28, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants