Fix ripple explorer (de)serialization issues #938
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes VSD-2389 and VSD-2405
Changes:
ledger_index_min
is now returned as a integer object and not a string-integer ; the synchronization fails at fetching the account transactions. Fix: changeledger_index_min
type from string to unsigned int64Amount
attribute is missing forAccountDelete
tx type. Fix: parseDeliveredAmount
, which is there for this tx type instead.Note: I would not suggest to use
delivered_amount
which seems always returned because I don't know how the parsing would go for other tx types, e.g. ifdelivered_amount
is always matchingAmount
(even if I suppose they will be always equal).Results:
sync successful, no error at sync, correct amount saved in db