Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix useObservable state generic inference #176

Merged

Conversation

OliverJAsh
Copy link
Contributor

@OliverJAsh OliverJAsh commented Feb 11, 2020

Fixes #171

I wanted to add a test for this, but I couldn't because #171 can only be reproduced when "strictFunctionTypes": false. (I have no idea why.)

@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #176 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #176   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          51     51           
  Branches        6      6           
=====================================
  Hits           51     51
Impacted Files Coverage Δ
src/use-observable.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b274449...9b60bf8. Read the comment docs.

Copy link
Contributor

@zry656565 zry656565 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zry656565 zry656565 merged commit fcbdb39 into LeetCode-OpenSource:master Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useObservable state generic is incorrectly inferred
2 participants