Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for __cpuidex in intrin.h #757

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeremyd2019
Copy link

This is what is actually used, rather than __cpuid. Due to what I assume is a bug in mingw-w64, __cpuid is prototyped on ARM64, even though there is no definition, which caused this check to succeed and compilation to later fail due to missing __cpuidex (it would have failed at link time if __cpuid was used instead)

This is what is actually used, rather than __cpuid.  Due to what I assume is a bug in mingw-w64, __cpuid is prototyped on ARM64, even though there is no definition, which caused this check to succeed and compilation to later fail due to missing __cpuidex (it would have failed at link time if __cpuid was used instead)
@jeremyd2019
Copy link
Author

jeremyd2019 commented Jul 27, 2023

I have separately reported the most likely erroneous presence of __cpuid prototype on ARM64 to mingw-w64. I just thought it also made sense to test for the intrinsic actually used here.

@jeremyd2019
Copy link
Author

I think mingw-w64/mingw-w64@69846cf would fix the build error on arm64, but I also think it would be more correct to check for __cpuidex since that is what will try to be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant