Force airtap's browserify to use buffer@5 #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ralphtheninja any ideas to solve this in a cleaner way? |
vweevers
commented
May 27, 2018
| @@ -59,7 +59,7 @@ | |||
| * Remove testling from `package.json` (@vweevers) | |||
| * Remove `level.js` logo (@vweevers) | |||
|
|
|||
| **Historical Note** As a result of removing `IDBWrapper`, only modern browsers with a non-prefixed `window.indexedDB` are supported in this release. IE10 and Firefox 52 are known to be broken. The current test matrix of `level-js` includes the latest versions of Chrome, Firefox, Safari, Edge and IE. | |||
There was a problem hiding this comment.
I removed this because it may lead people to believe we intend to fix IE10
Not sure we can? This works well enough I think. |
|
Alright |
ralphtheninja
approved these changes
May 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not the best solution but I want to trigger a Sauce Labs build. Closes #99.