-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Needs these fixes [from JayzTwoCentz video] #1393
Comments
Here is a list of what he requested in his video:
I've already started fixing some of those here. |
Dark mode is already an issue listed in #116. Would assume it's low in priority. |
@hcabel I believe he also requested a feature to make a custom defined interval for the scale of a data plot. |
.NET 9 may include new APIs for easy dark mode implementation |
@SirVingeTheSecond I cannot find it, send me the time code and I'll update the list. |
I think the time code is 12:43 (https://youtu.be/sX2ThUWNXio?t=763), but that is about the Y axis scale |
increase first start width / increase/resize column width - at 4:38 |
I would suggest to break those bullet points from Jay down into single issues and backlink these here. Assuming, that I am able to compile this project at my place I could try to tackle "Do not close dropdowns when checking/unchecking options". This can easily be handled by a small dialog instead of the menu structure. Menus always close when you click an item within. |
@Ironfist69 @hcabel @tryptichon Do not close dropdowns when checking/unchecking options Created |
"Do not close dropdowns when checking/unchecking options": |
@tryptichon Also, Maybe we should turn this into a 1 Click Application or if someone has a license and cert sign the application due to the traction it's getting from famous YouTuber (Just a thought). |
@xmikedanielsx |
Some of this stuff incl dark mode could easily be sorted using this open source github/NuGet packed. https:/MaterialDesignInXAML/MaterialDesignInXamlToolkit . I'm using it for 2 of my apps, and it works very well and very easy to set up for an existing .net project. And also in Visual studio, maybe make it into an .msi installer with they deployment project and I do this without any cert also. windows will just promt ppl with a warning. |
Yup, AGILE My Friend Agile! .. haha. Quick Fix until Good Fix :) |
If standard components were used for the tree view maybe. But it's nested in a bunch of custom components (aga Components). While possible It's a lot of work. Dark Mode is going to suck to do properly. UI will need to be torn apart it feels like.. I already started to take a stab at it and doing it a quick fix route. But it's trouble. Object. AllNodes Object.Nodes etc.. I am concentrating on other things atm so won't be for a little bit until I can focus on this again. But if you want to take it on by all means go for it. As for the msi installer or ClickOnce application by all means go for it. I mentioned it above as well. Keep in mind, there is no true need for it to be clickonce unless it's going to be maintained and the updates are published on web outside of GitHub for purposes of auto update. If not people will have to keep uninstalling and installing. But if we have anyone that wants to volunteer webspace for it. We can publish all of that to the webspace and enable auto update for the people that want it. I think the current format (after rethinking) makes sense to just be a runtime app. |
@xmikedanielsx The way I see it we can try to go one of two other routes:
|
I might take a swing at it. atm im just busy updating and adding a new addition to one of my apps. About the msi install I can see if no website ect, that might not the trouble worth. But my app dont have auto update. ppl just run a new version msi installer and it updates the already installed one. But to say I'm just a self learned C# hobby coder having some fun. I already downloaded the source to look at. If I get somewhere I will def hit you up in here. Great work btw. and Happy coding |
Yeah as I thought about it more. It makes more sense to be a runtime app or....... as you said (not me .. haha). Microsoft Store. |
Sorry was too fast to just use this NuGet packed. I thought the app was made in WPF and not windows forms. |
Well then ... throwing my "Quick Fix" into the ring. #1400 |
@tryptichon .. Well done. Looked at it. Not my favorite implementation as it is completely different from the rest of the menu and how it functions. But it does indeed solve his issue :) |
First steps towards the "Options Screen" you mentioned before. ;) |
@xmikedanielsx .... aaaaand done. 😁 |
@PhyxionNL - Quite a few outstanding PRs. Need help for QC or QA let the community know we can provide support. Let's keep the project moving ! . Go Devs Go! :) |
Little tip: If you wanted to keep your checklist up to date, instead of manually writing off the list, reference the issue (or better the applicable PR if present). If GitHub tracks this correctly, once closed the checkbox will be automatically ticked. |
i can take on dark mode |
Looks like all that's left is just verifying that Dark Mode isn't in a "broken" state via PR #847. Currently I believe what's blocking the PR from being merged is this issue here: #847 (comment) - although I'm unable to replicate this... for now. What we really need for traction is just QA testing this PR for any Dark Mode requests and try to break it if possible or further suggested improvements if any arise. |
Thanks for the tips, I didn't knew. |
Since I'm merely someone who'll contribute via PRs, I don't have maintaining rights. However, I do agree that some tagging could be a bit useful. Via labels could be some use. That being said, duplicates are bound to happen on any platform - it's a necessary evil that is impossible to avoid. Either by users desperately wanting something that they want to just write out what they want before utilizing the searching skills that they might have to search for duplicates first. Usually when I maintain repositories (at least recent ones), one of the first few requirements I make users fill out is "What keywords have you used for potential duplicates?" - That way, if the user hasn't done that yet, they get that opportunity to search first, and then either upvote what they want, or offer further suggestions. At the end of the day, end users who want to search for what's been already asked for will be through terminology that they are familiar with. |
100% agree with you. |
) * Add CSV file rotation method Add a new option to choose how the csv file is being rotated. Before it was everyday, which meant that we had to make sure the csv file was deleted before recording a new session. Now by default it's set to "Per session" meaning anytime you start a new session it create a new CSV file. Unless the daily method is used, in this case it will behave like before (1 file per day) * Scale up the first TreeView column ("Sensor") on resize The first ("Sensor") column being the most important and most likely the one that need the more space as hardware names can be pretty long. I've changed so that the first column is the one scaling up when the tree view is being resized (instead of the last one) * Change treeview column resize behaviour I've made so that the separator a controlling the size of the column to the left instead of the right. This make a lot easier to scale up the last column, but worth for the first one. Thought the previous commit made it so that the first column size is resize by the total with of the tree view. Sounds weird like that, but feel much more natural than before, and there is no overflow anymore. * Fix typo in daily file rotation menu item tool tip Co-authored-by: PhyxionNL <[email protected]> * Fix requested changes --------- Co-authored-by: PhyxionNL <[email protected]>
Youtube video link
The text was updated successfully, but these errors were encountered: