Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing: overload methods #336

Closed
wants to merge 6 commits into from
Closed

Typing: overload methods #336

wants to merge 6 commits into from

Conversation

Borda
Copy link
Member

@Borda Borda commented Jun 30, 2021 •
edited
Loading

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

see: python/mypy#1237
trying to solve:

error: Signature of "update" incompatible with supertype "Metric"  [override]

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the refactoring refactoring and code health label Jun 30, 2021
@Borda Borda requested a review from maximsch2 June 30, 2021 17:16
@Borda Borda requested a review from justusschock June 30, 2021 17:45
@Borda Borda closed this Jul 4, 2021
@Borda Borda deleted the typing/overload branch July 4, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximsch2 maximsch2 Awaiting requested review from maximsch2

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SkafteNicki SkafteNicki Awaiting requested review from SkafteNicki SkafteNicki will be requested when the pull request is marked ready for review SkafteNicki is a code owner

@stancld stancld Awaiting requested review from stancld stancld will be requested when the pull request is marked ready for review stancld is a code owner

Assignees
No one assigned
Labels
refactoring refactoring and code health
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Borda