Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conditional skip Doctests #759

Merged
merged 28 commits into from
Jan 17, 2022
Merged

conditional skip Doctests #759

merged 28 commits into from
Jan 17, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 14, 2022

What does this PR do?

Fixes #733

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added test / CI testing or CI refactoring refactoring and code health labels Jan 14, 2022
@Borda
Copy link
Member Author

Borda commented Jan 14, 2022

@stancld seems the docs example does not work as BERT requires models name... ^^

@Borda Borda added this to the v0.7 milestone Jan 14, 2022
Copy link
Contributor

@stancld stancld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to add model_name_or_path="roberta-base" manually if it works :]

torchmetrics/functional/text/bert.py Outdated Show resolved Hide resolved
torchmetrics/text/bert.py Outdated Show resolved Hide resolved
@Borda
Copy link
Member Author

Borda commented Jan 14, 2022

Let's try to add model_name_or_path="roberta-base" manually if it works :]

so it means that default none is not valid input...

@stancld
Copy link
Contributor

stancld commented Jan 14, 2022

Let's try to add model_name_or_path="roberta-base" manually if it works :]

so it means that default none is not valid input...

Unfortunately, it looks like so.. I'll send a quick fix tomorrow morning. It should be only about some input validation.

torchmetrics/text/bert.py Outdated Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Jan 16, 2022
torchmetrics/text/bert.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 16, 2022

Codecov Report

Merging #759 (af72349) into master (e87a85c) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #759   +/-   ##
=====================================
  Coverage      95%    95%           
=====================================
  Files         171    171           
  Lines        6898   6913   +15     
=====================================
+ Hits         6528   6555   +27     
+ Misses        370    358   -12     

@Borda Borda requested a review from stancld January 16, 2022 23:46
Co-authored-by: Daniel Stancl <[email protected]>
@Borda Borda enabled auto-merge (squash) January 16, 2022 23:48
@Borda Borda self-assigned this Jan 17, 2022
.github/workflows/ci_test-base.yml Show resolved Hide resolved
torchmetrics/detection/map.py Outdated Show resolved Hide resolved
torchmetrics/detection/map.py Outdated Show resolved Hide resolved
@Borda Borda requested a review from stancld January 17, 2022 00:21
Copy link
Contributor

@stancld stancld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ LGTM!

@mergify mergify bot added the ready label Jan 17, 2022
@Borda
Copy link
Member Author

Borda commented Jan 17, 2022

the HF cache seems strange as I still see time to time following download error:

>           raise HTTPError(http_error_msg, response=self)
E           requests.exceptions.HTTPError: 500 Server Error: Internal Server Error for url: https://huggingface.co/albert-base-v2/resolve/main/spiece.model

(mostly on MacOS)

@Borda Borda disabled auto-merge January 17, 2022 10:04
@Borda Borda merged commit e95c717 into master Jan 17, 2022
@Borda Borda deleted the doctests/skip branch January 17, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready refactoring refactoring and code health test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve doctests - conditional dependency skip
3 participants