Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various improvements for app startup #190

Merged
merged 12 commits into from
Nov 21, 2023
Merged

Various improvements for app startup #190

merged 12 commits into from
Nov 21, 2023

Conversation

HaronK
Copy link
Contributor

@HaronK HaronK commented Nov 21, 2023

  • Print application versions and build timestamp at startup
  • Compare Engine and script versions
  • Run tests in CI

HaronK
HaronK commented Nov 21, 2023
View reviewed changes
script/Main.lua Outdated Show resolved Hide resolved
HaronK
HaronK commented Nov 21, 2023
View reviewed changes
engine/bin/ltr/src/main.rs
env!("CARGO_PKG_VERSION"),
GIT_VERSION,
BUILD_TIME
);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will show in a log string like this:

App: ltr, ver: 0.1.0, git: latest-380-g03a57d95, build time: 2023-11-21 / 12:19:42 UTC

@IllustrisJack IllustrisJack mentioned this pull request Nov 21, 2023
Merged
@HaronK HaronK merged commit dcce31c into main Nov 21, 2023
4 checks passed
@HaronK HaronK deleted the haron/startup-fixes branch November 21, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IllustrisJack IllustrisJack IllustrisJack approved these changes

@dgavedissian dgavedissian Awaiting requested review from dgavedissian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HaronK @dgavedissian @IllustrisJack