Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csle tolerance tests #355

Merged
merged 18 commits into from
May 15, 2024
Merged

csle tolerance tests #355

merged 18 commits into from
May 15, 2024

Conversation

Yuhu-kth
Copy link
Collaborator

No description provided.

@Yuhu-kth
Copy link
Collaborator Author

Yuhu-kth commented May 3, 2024 •
edited
Loading

In the file
"csle/simulation-system/libs/csle-tolerance/tests/test_intrusion_response_cmdp_util.py", line #145-#147 :
Screenshot 2024-05-03 at 19 28 40

normalizing_constant is overwritten by line 151. So it's a bit weird to me.

@Limmen
Copy link
Owner

Limmen commented May 4, 2024

In the file "csle/simulation-system/libs/csle-tolerance/tests/test_intrusion_response_cmdp_util.py", line #145-#147 : Screenshot 2024-05-03 at 19 28 40

normalizing_constant is overwritten by line 151. So it's a bit weird to me.

Yes you are right, good catch @Yuhu-kth. You can remove the redundant lines, i.e, 145-147

Limmen
Limmen reviewed May 4, 2024
View reviewed changes
Copy link
Owner

@Limmen Limmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good so far. Lets continue with this PR until you completed all tests for csle-tolerance, then I will merge it and we can move on to the next task.

Limmen
Limmen reviewed May 14, 2024
View reviewed changes
simulation-system/libs/csle-tolerance/tests/test_pomdp_solve_parser.py
import numpy as np


class TestInstrusionTolerancePomdpSolveParserSuite:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good! I did not think you would be able to test this file :)

Limmen
Limmen requested changes May 15, 2024
View reviewed changes
Copy link
Owner

@Limmen Limmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, small things to fix

simulation-system/libs/csle-tolerance/src/csle_tolerance/envs/intrusion_recovery_pomdp_env.py Outdated
@@ -146,6 +146,7 @@ def _info(self, info: Dict[str, Any]) -> Dict[str, Any]:
upper_bound_return = 0
s = self.trace.states[0]
for i in range(len(self.trace.states)):
print(i)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove print statement

simulation-system/libs/csle-tolerance/src/csle_tolerance/util/general_util.py Outdated
@@ -73,6 +72,9 @@ def register_envs() -> None:

:return: None
"""
#import logging
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comments

@Limmen Limmen merged commit 2ad9273 into master May 15, 2024
@Limmen Limmen deleted the tolerance_tests branch May 15, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Limmen Limmen Limmen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yuhu-kth @Limmen