Select helper should still operate if its key parameter is set but resolves to undefined. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…solves to undefined.
sethkinast
force-pushed
the
select-key-undef
branch
from
44bb861
to
0a90948
Compare
|
LGTM |
Merged
prashn64
added a commit
that referenced
this pull request
Mar 3, 2015
Select helper should still operate if its key parameter is set but resolves to undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the corresponding change to #105 just for {@select} helpers instead.
This is a non-backwards-compatible change, but it makes sense to implement, especially since other comparators already work the same way.