Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure keepRunner from command line #67

Closed
wants to merge 1 commit into from

Conversation

mouyang
Copy link
Contributor

@mouyang mouyang commented Feb 8, 2014

As discussed in #64 (comment) - keepRunner is currently hardcoded and needs to be edited manually to keep the client-side specRunner after executing the jasmine:allTests task.

Using grunt.option allows this value to be configured through the command line. This also maintains backwards compatibility because the absence of this parameter on the command line means the return value is false.

@kate2753
Copy link
Contributor

We need little bit more clean up here. It's hard to debug code, since runner is using unminified dust helpers code. There are few other issues with they way it's currently set up.

Also, I would also encourage following what main dust project does with gruntbuild, so if somebody is contributing to both projects he or she does have to deal with two different build setups.

Main dust project uses grunt testClient task for this purpose. I've posted a pull request #69 to bring build for this project in line with core dust project.

@mouyang
Copy link
Contributor Author

mouyang commented Feb 17, 2014

@kate2753, it sounds like you would like me to wait until pull request #69 happens and before this one. I'm totally okay with that, let me know if that isn't what you want.

@sethkinast
Copy link
Contributor

The specRunner will stick around if you use grunt dev instead of grunt test, which allows you to see what's output. Because it's ephemeral and gets rebuilt every time we probably don't want to trick you into thinking that you can make changes to it that would be kept.

@sethkinast sethkinast closed this Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants