Update dev dependencies #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 13, 2020 07:35
|
Could you test this with the https:/Lombiq/Open-Source-Orchard-Core-Extensions solution as well, please? Just doing a build should be enough. |
Piedone
requested changes
Jan 7, 2021
| "gulp-sourcemaps": "2.6.5", | ||
| "gulp-watch": "5.0.1", | ||
| "node-sass": "4.14.1" | ||
| "node-sass": "^5.0.0" |
There was a problem hiding this comment.
I get 96 of these warnings on build:
cl : command line warning D9025: overriding '/GR-' with '/GR' [D:\Projects\src\Utilities\Lombiq.Gulp.Extensions\node_modules\node-sass\build\src\libsass.vcxproj] [D:\Projects\src\Utilities\Lombiq.Gulp.Extensions\Lombiq.Gulp.Extensions.csproj]
While this seems like an old error (see sass/node-sass#476 and sass/node-sass#467) it still happens for me on a fresh clone. Don't you see them?
|
We've updated these in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on this project I though I would align package versions with recent updates to Lombiq.Vuejs
Will need to merge #4 first if you would like to accept this PR.