Relative URL prefixed with /Admin in case of an admin controller action if [Route] attribute is used (OSOE-653)

[dministro]

The relative URL created by the TypedRoute.ToString() for a controller action where the controller has [Admin] attribute and the action has [Route] gets prefixed with /Admin. I think the expected result is the URL is not prefixed with /Admin.

Helpful-Libraries/Lombiq.HelpfulLibraries.OrchardCore/Mvc/TypedRoute.cs

Lines 92 to 101 in d5c11ae

	public override string ToString()
	{
	var prefix = _isAdminLazy.Value ? "/Admin/" : "/";
	var route = _routeLazy.Value;
	var arguments = _arguments.Any()
	? "?" + string.Join('&', _arguments.Select((key, value) => $"{key}={WebUtility.UrlEncode(value)}"))
	: string.Empty;
	return prefix + route + arguments;
	}

For the following example, the relative URL will be: /Admin/SampleModule/Admin/Edit

[Admin]
public class AdminController : Controller
{
    ...

    [Route("SampleModule/Edit")]
    public async Task<IActionResult> Edit(string contentItemId, string returnUrl)
    {
        ...
    }
}

Jira issue

[Piedone]

Just to confirm, this is only about actions with [Route], but without a manually defined route you still would expect the prefix, right?

[dministro]

Yes, if the action (without [Route(...)] attribute) is a member of an admin controller (with [Admin] attribute) I would expect the /Admin prefix.

[dministro]

I changed the route from SampleModule/Admin/Edit to SampleModule/Edit in the sample code in the issue description to make no confusion.

[Piedone]

I see, thanks.