Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SP-13295] Make this library more esm compatible and upgrades #33

Merged
merged 9 commits into from
Aug 30, 2024
Merged

[SP-13295] Make this library more esm compatible and upgrades #33

merged 9 commits into from
Aug 30, 2024

Conversation

eeerin
Copy link
Member

@eeerin eeerin commented Aug 29, 2024

  • regenerated yarn.lock
  • bumped any dependencies in the package.json to latest
  • moved from travis to github actions
  • updated src/index to not build isValid..functions by a loop

@eeerin eeerin requested a review from spacetc62 August 29, 2024 14:07
spacetc62
spacetc62 requested changes Aug 29, 2024
View reviewed changes
Copy link
Member

@spacetc62 spacetc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump package version to 4.1, update changelog

@eeerin eeerin requested a review from spacetc62 August 29, 2024 14:23
spacetc62
spacetc62 requested changes Aug 29, 2024
View reviewed changes
Copy link
Member

@spacetc62 spacetc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you bump .node-version to 20.16.0?

spacetc62
spacetc62 requested changes Aug 29, 2024
View reviewed changes
Copy link
Member

@spacetc62 spacetc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

husky is outputting install command is DEPRECATED

@eeerin eeerin requested a review from spacetc62 August 30, 2024 16:52
@spacetc62 spacetc62 merged commit cab278d into master Aug 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacetc62 spacetc62 spacetc62 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eeerin @spacetc62