random_album_id = '' causes exception in /gallery in LiveWire

[Electro707]

Lychee version

main, +6731535

Which PHP version are you using?

PHP 8.3

Detailed description of the problem

If the config random_album_id is set to an empty string, and Livewire is enabled, accessing /gallery/ results in an exception.

I have traced the cause down to the checkFrameAccess function in Livewire/Components/Pages/Gallery/Albums.php, where the $randomalbumid is not checked if it's empty before the findAbstractAlbumOrFail is called

		$randomAlbumId = Configs::getValueAsString('random_album_id');
		$album = resolve(AlbumFactory::class)->findAbstractAlbumOrFail($randomAlbumId);

I am not familiar enough with the codebase to come up with a good fix myself. I would like to think if the album ID is empty, then frame access is allowed unless there's no image to be shown.

Steps to reproduce the issue

• Set random_album_id to an empty string ''
• try to access /gallery

Diagnostics [REQUIRED]

    Diagnostics
    -----------
        Warning: /***************ic/uploads/ has permissions 0775, but should have 2775
        Warning: /***************ic/uploads/small2x has permissions 0775, but should have 2775
        Warning: /***************ic/uploads/small2x/55 has permissions 0775, but should have 2775
        Warning: /***************ic/uploads/small2x/55/ae has permissions 0775, but should have 2775
        Warning: /***************ic/uploads/original has permissions 0775, but should have 2775
        Warning: 29 more directories with wrong permissions
        Warning: Dropbox import not working. dropbox_key is empty.
        Warning: Default timezone not properly set; you might experience strange results when importing photos without explicit EXIF timezone
        Error: /s************it (and subdirectories) are not executable, check the permissions
    

    System Information
    ------------------
        Lychee Version (git):                    master (6731535) -- Up to date (-6.6939370877727E-11 years ago).
        DB Version:                              5.5.1
        
        composer install:                        dev
        APP_ENV:                                 development
        APP_DEBUG:                               false
        APP_URL:                                 set
        APP_DIR:                                 default
        LOG_VIEWER_ENABLED:                      true
        LIVEWIRE_ENABLED:                        true
        
        System:                                  Linux
        PHP Version:                             8.3.11
        PHP User agent:                          Lychee/4 (https://lycheeorg.github.io/)
        Timezone:                                UTC
        Max uploaded file size:                  500M
        Max post size:                           500M
        Livewire chunk size:                     12.00 MB
        Max execution time:                      200
        SQLite Version:                          3.46.1
        
        exec() Available:                        yes
        Imagick Available:                       1
        Imagick Enabled:                         1
        Imagick Version:                         1809
        GD Version:                              2.3.3
        Number of foreign key:                   11 found.
    

    Config Information
    ------------------
        version:                                 050501
        check_for_updates:                       0
        sorting_photos_col:                      taken_at
        sorting_photos_order:                    ASC
        sorting_albums_col:                      max_taken_at
        sorting_albums_order:                    ASC
        imagick:                                 1
        skip_duplicates:                         0
        small_max_width:                         0
        small_max_height:                        360
        medium_max_width:                        1920
        medium_max_height:                       1080
        lang:                                    en
        image_overlay_type:                      desc
        default_license:                         none
        compression_quality:                     90
        grants_full_photo_access:                1
        delete_imported:                         0
        mod_frame_enabled:                       1
        mod_frame_refresh:                       30
        thumb_2x:                                1
        small_2x:                                1
        medium_2x:                               1
        landing_page_enable:                     0
        force_migration_in_production:           0
        search_public:                           0
        hide_version_number:                     0
        SL_enable:                               0
        SL_for_admin:                            0
        recent_age:                              1
        grants_download:                         0
        photos_wraparound:                       1
        map_display:                             0
        zip64:                                   1
        map_display_public:                      0
        map_provider:                            Wikimedia
        force_32bit_ids:                         0
        map_include_subalbums:                   0
        update_check_every_days:                 3
        has_exiftool:                            0
        share_button_visible:                    0
        import_via_symlink:                      0
        has_ffmpeg:                              1
        location_decoding:                       0
        location_decoding_timeout:               30
        location_show:                           1
        location_show_public:                    0
        rss_enable:                              0
        rss_recent_days:                         7
        rss_max_items:                           100
        prefer_available_xmp_metadata:           0
        editor_enabled:                          1
        lossless_optimization:                   0
        swipe_tolerance_x:                       150
        swipe_tolerance_y:                       250
        local_takestamp_video_formats:           .avi|.mov
        log_max_num_line:                        1000
        unlock_password_photos_with_url_param:   0
        nsfw_visible:                            1
        nsfw_blur:                               0
        nsfw_warning:                            0
        nsfw_warning_admin:                      0
        nsfw_banner_override:                    
        map_display_direction:                   1
        album_subtitle_type:                     oldstyle
        upload_processing_limit:                 4
        new_photos_notification:                 0
        legacy_id_redirection:                   1
        zip_deflate_level:                       6
        default_album_protection:                1
        album_decoration:                        layers
        album_decoration_orientation:            row
        allow_username_change:                   1
        auto_fix_orientation:                    1
        use_job_queues:                          0
        random_album_id:                         
        use_last_modified_date_when_no_exif_date: 0
        layout:                                  justified
        date_format_photo_thumb:                 M j, Y, g:i:s A e
        date_format_photo_overlay:               M j, Y, g:i:s A e
        date_format_sidebar_uploaded:            M j, Y, g:i:s A e
        date_format_sidebar_taken_at:            M j, Y, g:i:s A e
        date_format_hero_min_max:                F Y
        date_format_hero_created_at:             M j, Y, g:i:s A T
        date_format_album_thumb:                 M Y
        upload_chunk_size:                       0
        nsfw_banner_blur_backdrop:               0
        search_pagination_limit:                 1000
        search_minimum_length_required:          4
        photo_layout_justified_row_height:       320
        photo_layout_masonry_column_width:       300
        photo_layout_grid_column_width:          250
        photo_layout_square_column_width:        200
        photo_layout_gap:                        12
        display_thumb_album_overlay:             always
        display_thumb_photo_overlay:             hover
        default_album_thumb_aspect_ratio:        1/1
        use_album_compact_header:                0
        login_button_position:                   left
        back_button_enabled:                     0
        back_button_text:                        Return to Home
        current_job_processing_visible:          1
        SA_random_thumbs:                        0
        job_processing_queue_visible:            1
        login_required:                          0
        enable_unsorted:                         1
        enable_starred:                          1
        enable_recent:                           1
        enable_on_this_day:                      1
        login_required_root_only:                1

Browser & System [REQUIRED]

Arch Linux, Firefox

Please confirm (incomplete submissions will not be addressed)

• I have provided easy and step-by-step instructions to reproduce the bug.
• I understand my bug report will be removed if I haven't met the criteria above.

[ildyria]

Hi, thank you for your report.

That bug will be gone (hopefully) once I releave v6. Nevertheless, that is an oversight. random_album_id should not be an empty string but one of the album id either a smart one like starred (default value if I am not wrong) or the id of an album.

I think I will need to make a config check in the diagnostics for that one. :/

[ildyria]

Should be fixed in v6. :)