Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: light theme for Lychee #2086

Open
neurosatan opened this issue Apr 10, 2019 · 9 comments · May be fixed by #2504
Open

Feature request: light theme for Lychee #2086

neurosatan opened this issue Apr 10, 2019 · 9 comments · May be fixed by #2504
Labels
enhancement New feature or request good first issue Good for newcomers Project for volunteers The team has no plans to work on it (e.g. lack of time) but an external contribution is accepted

Comments

@neurosatan
Copy link

hi, pls add light theme for Lychee.

Example
000

@ildyria ildyria transferred this issue from LycheeOrg/Lychee-v3 Apr 10, 2019
@ildyria ildyria added the enhancement New feature or request label Apr 10, 2019
@kamil4
Copy link
Contributor

kamil4 commented Apr 10, 2019

Hopefully none of the color information is hard-coded in JS and is instead all in CSS? This sounds like a good project for somebody who would like to contribute but is not a programmer. It's possibly even doable by ordinary users by providing a personalized user.css in the Settings.

@ildyria ildyria added the good first issue Good for newcomers label Apr 10, 2019
@SerenaButler
Copy link
Contributor

SerenaButler commented Apr 23, 2019

As a starting point. My Light Theme for Lychee. It's rough css.

user.css.txt

@Renset
Copy link

Renset commented Sep 18, 2022

Finally, I'm working on a white theme for Lychee v4 for my own purposes. Probably I can try to create a pull request for this feature if it makes sense

@kamil4
Copy link
Contributor

kamil4 commented Sep 20, 2022

I for one would be in favor of having a light theme as an option. You may want to check LycheeOrg/Lychee-front#269 that was supposed to clean up our color management and thus make any subsequent color theming easier. I feel that it would be beneficial to get that PR cleaned up and merged first...

@nspirov
Copy link

nspirov commented Apr 10, 2023

I'd like to add to this issue that there are users for whom the dark theme is a SERIOUS problem. I have impaired vision and I am literally unable to use Lychee unless there is a different theme. The menus and all dialogs are just dancing in front of me.
I hope the developers will take this into account. I, for example, would be a paid user if I could, well, use it.

@qwerty287
Copy link
Contributor

There's https:/Renset/lychee-flat-white-theme which seems to be pretty up-to-date. However, I don't know if it works (it's not developed by us).

@nspirov
Copy link

nspirov commented Apr 10, 2023

There's https:/Renset/lychee-flat-white-theme which seems to be pretty up-to-date. However, I don't know if it works (it's not developed by us).

Ah thanks, I saw it above. I'll try it.

@ildyria ildyria transferred this issue from LycheeOrg/Lychee-front Dec 25, 2023
@ildyria ildyria added the Project for volunteers The team has no plans to work on it (e.g. lack of time) but an external contribution is accepted label Dec 28, 2023
@lukewatts
Copy link

Since we're using Tailwind, it might make more sense to make the default theme light, and then we can use the darkMode correctly to easily offer both to all users with a simple dropdown, like the Tailwind site does...

tailwind-dark-mode

Then we have the added benefit of being able to allow users to use whatever their OS/system is set to and easily add new themes via the tailwind config: overriding the dark variant

I've got some ideas on this, so I'll take a deeper look into it and see if it's something that can be done easily via the above methods.

@ildyria
Copy link
Member

ildyria commented Feb 28, 2024

Hi @lukewatts
I know that tailwind support the dark: attribute but I didn't feel like annotating the full html to support the duality of settings.

This work has been done too:
https:/Renset/lychee-flat-white-theme

One thing I paid attention to was to not use tailwind predefined colors in order to make them more extendable for other users:
https:/LycheeOrg/Lychee/blob/master/resources/css/app.css

@ildyria ildyria linked a pull request Oct 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Project for volunteers The team has no plans to work on it (e.g. lack of time) but an external contribution is accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants