Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Lobby Display #23

Merged
merged 5 commits into from
Nov 7, 2022
Merged

Change Lobby Display #23

merged 5 commits into from
Nov 7, 2022

Conversation

raw-chicken
Copy link
Contributor

Change lobby display so that it'll display as two rows instead of sometimes changing to one long row of 10 champions.

@raw-chicken
Copy link
Contributor Author

Made it so that if you are looking at settings and click profile/lobby, then the settings will close.

@raw-chicken
Copy link
Contributor Author

When Lytical is waiting for a response in lobby, it will display "Loading..." so that it's not just a blank screen. (No animation tho)

@raw-chicken
Copy link
Contributor Author

  • Added the loading animation for the Lobby
  • Formatted some of the code to keep code consistent (at 2 space indents)
  • Clicking anywhere in MatchHistoryItem will open details (other than clicking on the champion, which will open champ page)

@downthecrop
Copy link
Contributor

I should break out the loading dots into a component. Good changes. Thank you!

@downthecrop downthecrop merged commit 060f780 into LyticalApp:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants