Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify deployment - remove nginx service #21

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

MDeLuise
Copy link
Owner

@MDeLuise MDeLuise commented Sep 8, 2023

This PR simplify the deployment removing the nginx reverse proxy service.
This leads to the following improvements:

  • less service used, more lightweight deployment
  • possibility of changing backend and frontend services' port binding indipendently
  • possibility of more granular CORS filtering in the backend

Also in this PR:

  • renames FRONTEND_URL parameter (backend.env) to a more clear ALLOWED_ORIGINS
  • updates the main README of the app
  • set a fixed version for redis and mysql services
  • fix requirement java version in the README
  • add a check for backend available in the authentication window
  • better error rendering in the authentication window

@MDeLuise MDeLuise added the Type: Enhancement Improvements label Sep 8, 2023
@MDeLuise MDeLuise merged commit 54b3b30 into main Sep 8, 2023
6 checks passed
@MDeLuise MDeLuise deleted the feature-simplify-deployment branch September 8, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant