Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display credentialing status on event management page. Fixes #2163. #2174

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

tompollard
Copy link
Member

As discussed in #2163, the "credentialed" column on the event management page should display whether or not an event participant is credentialed.

As a result of a bug in the template, the credentialing status is not displayed. This pull request is a minor update to fix the bug. I also remove a couple of unused columns at the same time (e.g. "co-host").

@tompollard
Copy link
Member Author

tompollard commented Jan 8, 2024

@mscanlan-git please could you test this and merge if you are happy? To test:

  1. Run git pull to pull down the branch
  2. Check out the branch (git switch tp/event_credentialed)
  3. Run the local server as usual. Check that the credentialing status is now displayed correctly (rgmark and aewj are credentialed users).

We need to think more about whether displaying the credentialing status is enough. For example, should we also display:

  1. training status?
  2. details on which DUAs have been signed?

I think we should raise a new issue to discuss these points (and address them in a later pull request).

@mscanlan-git
Copy link
Contributor

Thanks @tompollard, this is working as intended.

I do think we should have a column for training status and DUAs, as these are two additional requirements that users will need to complete. Having all 3 columns available to the event host will make it easier to pinpoint why a user is unable to access the datasets for that event. I will create an issue to note.

@mscanlan-git mscanlan-git merged commit 613373b into dev Jan 8, 2024
11 checks passed
@tompollard tompollard deleted the tp/event_credentialed branch January 8, 2024 17:57
@tompollard
Copy link
Member Author

Thanks Michael! I have pushed the fix to the live server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants