Handle missing contact address in project_submission #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the submission page we display a contact address for the project editor, if one has been assigned. If no editor has yet been assigned, then the "contact_email" won't be shown. However, if no editor has yet been assigned (self.editor is None) and there is no PROJECT_EDITOR_EMAIL defined, the previous code would crash. Put this logic into the model class, not the view, and document it.
|
thanks for catching this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull #2156 introduced the PROJECT_EDITOR_EMAIL setting.
If this setting is not defined (or blank) then we want to fall back to the old behavior of showing the assigned editor's email address.
However, if the project has not yet been assigned to an editor, and PROJECT_EDITOR_EMAIL is blank, it would crash.
(For example, clear the PROJECT_EDITOR_EMAIL setting, then log in as rgmark and try to submit the "MIMIC-III Clinical Database" project.)