Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Création de l'onglet imperméabilisation #493

Merged
merged 8 commits into from
Jul 4, 2024
Merged

Création de l'onglet imperméabilisation #493

merged 8 commits into from
Jul 4, 2024

Conversation

smdsgn
Copy link
Collaborator

@smdsgn smdsgn commented Jul 2, 2024 •
edited by alexisig
Loading

image

@smdsgn smdsgn self-assigned this Jul 2, 2024
@smdsgn smdsgn requested a review from alexisig July 2, 2024 07:55
@alexisig alexisig changed the base branch from freeze to staging July 3, 2024 08:16
@alexisig alexisig linked an issue Jul 3, 2024 that may be closed by this pull request
Création page imperméabilisation #494
Closed
alexisig
alexisig requested changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@alexisig alexisig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, quelques modifs d'éléments restés similaires à l'artif mis en suggestion

project/templates/project/report_imper.html Outdated Show resolved Hide resolved
project/templates/project/report_imper.html Outdated Show resolved Hide resolved
project/templates/project/report_imper.html Outdated Show resolved Hide resolved
project/templates/project/report_imper.html Outdated Show resolved Hide resolved
project/templates/project/report_imper.html Outdated Show resolved Hide resolved
project/templates/project/report_imper.html Outdated Show resolved Hide resolved
public_data/templates/public_data/partials/imper_nette_table.html Outdated Show resolved Hide resolved
public_data/templates/public_data/partials/imper_sol_table.html Outdated Show resolved Hide resolved
project/templates/project/report_imper.html Outdated Show resolved Hide resolved
project/templates/project/report_imper.html Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 4, 2024

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@smdsgn smdsgn merged commit 0d32fb5 into staging Jul 4, 2024
5 checks passed
@smdsgn smdsgn deleted the feature/imper-report-tab branch July 4, 2024 15:29
@Phil-Loriot
Copy link
Collaborator

OK pour moi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexisig alexisig alexisig requested changes

Assignees

@smdsgn smdsgn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Création page imperméabilisation
3 participants
@smdsgn @Phil-Loriot @alexisig